fix(config): changed two feature flags types from boolean to string. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging two configurations - the default one defined in the application’s code and the user-defined one - if a feature flag is set to false in the user config but set to true in the default config, the default value will take precedence over the user-defined value. In such case, it is impossible to disable the feature.
kkotula
force-pushed
the
fix(config)/unoverridable_feature_flags
branch
from
30d093a to
e93a989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging two configurations - the default one defined in the application’s code and the user-defined one - if a feature flag is set to false in the user config but set to true in the default config, the default value will take precedence over the user-defined value. In such case, it is impossible to disable the feature.